Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

staticdata: Fix typo in recursive edge revalidation #57383

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Conversation

Keno
Copy link
Member

@Keno Keno commented Feb 12, 2025

Addresses mystery #3 in #57381 (and extends the test from that issue).

@Keno Keno added the embarrassing-bugfix Whoops! label Feb 12, 2025
@Keno Keno changed the base branch from kf/37318 to master February 13, 2025 05:39
Addresses mystery #3 in #57381 (and extends the test from that issue).
@vtjnash
Copy link
Member

vtjnash commented Feb 13, 2025

      From worker 10:	[10929] signal 11 (128): Segmentation fault
2025-02-13 01:23:32 EST	      From worker 10:	in expression starting at none:0
2025-02-13 01:23:32 EST	      From worker 10:	jl_to_typeof at /cache/build/builder-amdci4-6/julialang/julia-master/src/julia.h:921 [inlined]
2025-02-13 01:23:32 EST	      From worker 10:	ijl_subtype_env at /cache/build/builder-amdci4-6/julialang/julia-master/src/subtype.c:2216
2025-02-13 01:23:32 EST	      From worker 10:	ijl_isa at /cache/build/builder-amdci4-6/julialang/julia-master/src/subtype.c:2492
2025-02-13 01:23:32 EST	      From worker 10:	jl_tuple1_isa at /cache/build/builder-amdci4-6/julialang/julia-master/src/subtype.c:2381
2025-02-13 01:23:32 EST	      From worker 10:	jl_typemap_entry_assoc_exact at /cache/build/builder-amdci4-6/julialang/julia-master/src/typemap.c:1154
2025-02-13 01:23:32 EST	      From worker 10:	jl_typemap_assoc_exact at /cache/build/builder-amdci4-6/julialang/julia-master/src/julia_internal.h:1746 [inlined]
2025-02-13 01:23:32 EST	      From worker 10:	jl_lookup_generic_ at /cache/build/builder-amdci4-6/julialang/julia-master/src/gf.c:3609 [inlined]
2025-02-13 01:23:32 EST	      From worker 10:	ijl_apply_generic at /cache/build/builder-amdci4-6/julialang/julia-master/src/gf.c:3671
2025-02-13 01:23:32 EST	      From worker 10:	unsafe_convert at ./refvalue.jl:39
2025-02-13 01:23:32 EST	      From worker 10:	push! at ./idset.jl:57
2025-02-13 01:23:32 EST	      From worker 10:	unknown function (ip: 0x7fcbd64fe7c6) at (unknown file)
2025-02-13 01:23:32 EST	      From worker 10:	typeinf_ext_toplevel at ./../usr/share/julia/Compiler/src/typeinfer.jl:1266
2025-02-13 01:23:32 EST	      From worker 10:	unknown function (ip: 0x7fcbd64e09b2) at (unknown file)
2025-02-13 01:23:32 EST	      From worker 10:	jl_apply at /cache/build/builder-amdci4-6/julialang/julia-master/src/julia.h:2300 [inlined]
2025-02-13 01:23:32 EST	      From worker 10:	jl_type_infer at /cache/build/builder-amdci4-6/julialang/julia-master/src/gf.c:453
2025-02-13 01:23:32 EST	      From worker 10:	jl_compile_method_internal at /cache/build/builder-amdci4-6/julialang/julia-master/src/gf.c:2972
...
2025-02-13 01:23:32 EST	      From worker 10:	jl_type_infer at /cache/build/builder-amdci4-6/julialang/julia-master/src/gf.c:453
....
2025-02-13 01:23:32 EST	      From worker 10:	jl_compile_method_internal at /cache/build/builder-amdci4-6/julialang/julia-master/src/gf.c:2972
...
2025-02-13 01:23:32 EST	      From worker 10:	jl_module_run_initializer at /cache/build/builder-amdci4-6/julialang/julia-master/src/toplevel.c:75

@vtjnash vtjnash merged commit cff8bd6 into master Feb 13, 2025
5 of 7 checks passed
@vtjnash vtjnash deleted the kf/validatetypo branch February 13, 2025 13:50
@KristofferC KristofferC added the backport 1.12 Change should be backported to release-1.12 label Feb 14, 2025
KristofferC pushed a commit that referenced this pull request Feb 14, 2025
Addresses mystery #3 in #57381 (and extends the test from that issue).

(cherry picked from commit cff8bd6)
@KristofferC KristofferC mentioned this pull request Feb 14, 2025
31 tasks
KristofferC added a commit that referenced this pull request Feb 17, 2025
Backported PRs:
- [x] #57346 <!-- lowering: Only try to define the method once -->
- [x] #57341 <!-- bpart: When backdating replace the entire bpart chain
-->
- [x] #57381 <!-- staticdata: Set min validation world to require world
-->
- [x] #57357 <!-- Only implicitly `using` Base, not Core -->
- [x] #57383 <!-- staticdata: Fix typo in recursive edge revalidation
-->
- [x] #57385 <!-- bpart: Move kind enum into its intended place -->
- [x] #57275 <!-- Compiler: fix unsoundness of getfield_tfunc on Tuple
Types -->
- [x] #57378 <!-- print admonition for auto-import only once per module
-->
- [x] #57392 <!-- [LateLowerGCFrame] fix PlaceGCFrameReset for
returns_twice -->
- [x] #57388 <!-- Bump JuliaSyntax to v1.0.2 -->
- [x] #57266 <!-- 🤖 [master] Bump the Statistics stdlib from d49c2bf to
77bd570 -->
- [x] #57395 <!-- lowering: fix has_fcall computation -->
- [x] #57204 <!-- Clarify mathematical definition of `gcd` -->
- [x] #56794 <!-- Make `Pairs` public -->
- [x] #57407 <!-- staticdata: corrected implementation of
jl_collect_new_roots -->
- [x] #57405 <!-- bpart: Also partition the export flag -->
- [x] #57420 <!-- Compiler: Fix check for IRShow definedness -->
- [x] #55875 <!-- fix `(-Inf)^-1` inconsistency -->
- [x] #57317 <!-- internals: add _defaultctor function for defining
ctors -->
- [x] #57406 <!-- bpart: Ignore guard bindings for ambiguity purposes
-->
- [x] #49933 <!-- Allow for :foreigncall to transition to GC safe
automatically -->
@KristofferC KristofferC removed the backport 1.12 Change should be backported to release-1.12 label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants